From b7fab13d4d5730d937b5b1aa9ad109488277dfb4 Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Fri, 11 Oct 2019 15:56:51 +0100 Subject: [PATCH] x86/VT-d: Drop unhelpful information in diagnostics MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The virtual address of the base of the IOMMU's regsters is not useful for diagnostic purposes, and is quite voluminous. The PCI coordinates is by far the most useful piece of identifying information. Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Acked-by: Jan Beulich Release-acked-by: Juergen Gross --- xen/drivers/passthrough/vtd/iommu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c index f08eec070d..0522ecd3bc 100644 --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -842,26 +842,26 @@ static int iommu_page_fault_do_one(struct vtd_iommu *iommu, int type, case DMA_REMAP: printk(XENLOG_G_WARNING VTDPREFIX "DMAR:[%s] Request device [%04x:%02x:%02x.%u] " - "fault addr %"PRIx64", iommu reg = %p\n", + "fault addr %"PRIx64"\n", (type ? "DMA Read" : "DMA Write"), seg, PCI_BUS(source_id), PCI_SLOT(source_id), - PCI_FUNC(source_id), addr, iommu->reg); + PCI_FUNC(source_id), addr); kind = "DMAR"; break; case INTR_REMAP: printk(XENLOG_G_WARNING VTDPREFIX "INTR-REMAP: Request device [%04x:%02x:%02x.%u] " - "fault index %"PRIx64", iommu reg = %p\n", + "fault index %"PRIx64"\n", seg, PCI_BUS(source_id), PCI_SLOT(source_id), - PCI_FUNC(source_id), addr >> 48, iommu->reg); + PCI_FUNC(source_id), addr >> 48); kind = "INTR-REMAP"; break; default: printk(XENLOG_G_WARNING VTDPREFIX "UNKNOWN: Request device [%04x:%02x:%02x.%u] " - "fault addr %"PRIx64", iommu reg = %p\n", + "fault addr %"PRIx64"\n", seg, PCI_BUS(source_id), PCI_SLOT(source_id), - PCI_FUNC(source_id), addr, iommu->reg); + PCI_FUNC(source_id), addr); kind = "UNKNOWN"; break; } -- 2.30.2